michael-hoke commented on code in PR #1336:
URL: https://github.com/apache/daffodil-vscode/pull/1336#discussion_r2254953984
##########
src/adapter/activateDaffodilDebug.ts:
##########
@@ -399,51 +426,44 @@ export function activateDaffodilDebug(
context.subscriptions.push(
vscode.commands.registerCommand(
'extension.dfdl-debug.getTDMLName',
- async (config) => {
+ async (tdmlConfigPath) => {
// Config item gets passed
// get test case name options for dropdown
- const test_case_names: string[] = getTDMLTestCaseItems(
- config?.tdmlConfig?.path
- )
+ const test_case_names: string[] = getTDMLTestCaseItems(tdmlConfigPath)
Review Comment:
If this returns an empty list, we shouldn't even be calling the getTDMLName
(or Description) functions. We should be returning empty immediately, and the
caller should see that and abort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
