JeremyYao commented on code in PR #1336:
URL: https://github.com/apache/daffodil-vscode/pull/1336#discussion_r2255115470
##########
src/adapter/activateDaffodilDebug.ts:
##########
@@ -168,35 +168,52 @@ function createDebugRunFileConfigs(
tdmlConfig.action = tdmlAction
if (tdmlAction === 'execute') {
- tdmlConfig.name = '${command:AskForTDMLName}'
- tdmlConfig.description = '${command:AskForTDMLDescription}'
- tdmlConfig.path = targetResource.fsPath
+ tdmlConfig.path = targetResource.fsPath.toString()
+
+ tdmlConfig.name =
+ tdmlConfig.name ||
+ (await vscode.commands.executeCommand(
+ 'extension.dfdl-debug.getTDMLName',
+ tdmlConfig.path
+ ))
+
+ tdmlConfig.description =
+ tdmlConfig.description ||
+ (await vscode.commands.executeCommand(
+ 'extension.dfdl-debug.getTDMLDescription',
+ tdmlConfig.path
+ ))
+
+ if (!tdmlConfig.name || !tdmlConfig.description) {
+ vscode.window.showErrorMessage(
Review Comment:
That's a good point. It doesn't align with the user pressing Esc on one of
the dropdowns. I addressed your point in
https://github.com/apache/daffodil-vscode/pull/1336/commits/7f69b20b7b31788c7bcc019f166c3d2ac598e9fb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
