stevedlawrence commented on code in PR #1452:
URL: https://github.com/apache/daffodil-vscode/pull/1452#discussion_r2417081307
##########
package.json:
##########
@@ -685,8 +689,18 @@
},
"dfdlDebugger": {
"type": "object",
- "description": "Configuration for debugger. Settings are
logging (level and file)",
+ "description": "Configuration for debugger. Settings are
version (any valid Daffodil version), timeout and logging (level and file)",
"properties": {
+ "version": {
Review Comment:
Should this be renamed "daffodilVersion", to make it clear this is about
daffodil and not the version of the debugger?
##########
debugger/src/main/scala-2.12/org.apache.daffodil.debugger.dap/Convert.scala:
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/** This file contains support code for making a majority of Scala shareable
between different versions of Scala and
+ * Daffodil. The main difference comes in package names, converting certain
variables, etc. This file has all the
+ * helper code for that for Scala 2.13.
+ */
+
+package org.apache.daffodil.debugger.dap
+
+import scala.collection.JavaConverters._
Review Comment:
If you add the `scala-collection-compat` library to `libraryDependencies`
for the scala-2.12 matrix, you can import `scala.jdk.CollectionConverters._`
when building with 2.12. So I think that would make a good chunk of this
Convert object go away and you can undo many of the changes made to shared
scala sources.
Should just be a minor tweak to `getPlatformSpecificLibraries` to add this
when `scalaBinaryVersion` is 2.12:
```
"org.scala-lang.modules" %% "scala-collection-compat" % "2.14.0"
```
I think the Maybe toOption thing would be the only thing you need in the
Conver object?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
