stevedlawrence commented on code in PR #1452:
URL: https://github.com/apache/daffodil-vscode/pull/1452#discussion_r2413696376
##########
vite/package.vite.config.mjs:
##########
@@ -109,23 +121,38 @@ function copyToPkgDirPlugin() {
{ from: 'src/styles/styles.css', to: `${pkg_dir}/src/styles/styles.css` },
{ from: 'src/tdmlEditor/', to: `${pkg_dir}/src/tdmlEditor` },
]
- const serverPackageFolder = path.join(
- path.resolve('dist/package'),
- serverPackage
- )
-
- console.debug(`== [Vite] | serverPackageFolder: ${serverPackageFolder}`)
- // remove debugger package folder if exists
- if (fs.existsSync(serverPackageFolder)) {
- fs.rmSync(serverPackageFolder, { recursive: true })
+
+ const serverPackageFolders = {
+ scala2_12: path.join(
+ path.resolve('dist/package'),
+ `daffodil-debugger-${daffodilVersions['scala2.12']}-${pkg_version}`
+ ),
+ scala2_13: path.join(
+ path.resolve('dist/package'),
+ `daffodil-debugger-${daffodilVersions['scala2.13']}-${pkg_version}`
+ ),
+ scala3: path.join(
+ path.resolve('dist/package'),
+ `daffodil-debugger-${daffodilVersions['scala3']}-${pkg_version}`
+ ),
Review Comment:
> So the main reason I did limit it to 3 was because I didn't think we would
want to support every version of Daffodil right off the bat.
I don't think that's unreasonable. It the concern is just having to support
untested versions we could always allow users to select different versions and
show a warning, or only let them select from a supported version and have an
advance mode that allows custom input.
> it sounds like you are saying to download the Daffodil CLI debugger and
run that instead of this custom debugger is that right?
I'm just suggesting to download the CLI for the daffodil jars--it's an easy
way to get the official jars any official daffodil release without having to
package the jars somewhere else. Some of the jars like daffodil-cli.jar might
be on the classpath but would essentially be ignored because the entrypoint
would be your daffodil-debugger.jar, which would never use anything in
daffodil-cli. So instead of bundling all the daffodil jars version multiple
versions in the extension, you just download the daffodil release that you
need. Note that I built the vsix from this PR and it came to 237M. That's
really huge, partly because it's bundling multiple versions of Daffodil. If we
could only download what we need, and maybe bundle one version, that would
probably make it quite a bit smaller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
