shanedell commented on code in PR #1471:
URL: https://github.com/apache/daffodil-vscode/pull/1471#discussion_r2453199911


##########
vite/dev.vite.config.mjs:
##########
@@ -45,41 +45,30 @@ const packageData = jsoncParse(
 const pkg_version = packageData['version']
 const scalaVersions = ['2.12', '2.13', '3']
 
-function unzipAfterBuild() {
+function copyDebuggerOutAfterBuild() {

Review Comment:
   Instead of it being in `dist/package` I might do `dist/debuggers`. I believe 
`dist/package` is the root directory where we store all the files to be made 
into the VSIX.
   
   Here is the mapping of some files:
   
   - The extension code lives at `dist/ext` during development and at 
`dist/package/dist/ext` during packaging
   - The data editor and tdml editor views lives at `dist/views/` during 
development and at `dist/package/dist/views/
   
   So, I think doing `dist/debuggers` during development and 
`dist/package/dist/debuggers` during packaging will be good and follow our 
current scheme.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to