shanedell commented on code in PR #1471:
URL: https://github.com/apache/daffodil-vscode/pull/1471#discussion_r2455472310
##########
vite.config.mjs:
##########
@@ -142,72 +143,70 @@ function copyToPkgDirPlugin() {
name: 'copy-patterns-plugin',
apply: 'build',
async buildStart(opts) {
- if (!fs.existsSync(pkg_dir)) {
- serverPackageFolders.forEach((serverPackageFolder) => {
- fs.mkdirSync(serverPackageFolder, { recursive: true })
- })
- fs.mkdirSync(pkg_dir + '/dist')
- fs.mkdirSync(pkg_dir + '/src/language', {
- recursive: true,
- })
- fs.mkdirSync(pkg_dir + '/src/language/providers', {
- recursive: true,
- })
- fs.mkdirSync(pkg_dir + '/src/language/providers/intellisense/', {
- recursive: true,
- })
- fs.mkdirSync(pkg_dir + '/src/launchWizard', {
- recursive: true,
- })
- fs.mkdirSync(pkg_dir + '/src/styles', {
- recursive: true,
- })
- fs.mkdirSync(pkg_dir + '/src/tdmlEditor', {
- recursive: true,
- })
- }
+ ;[
+ pkg_dir + '/dist',
+ pkg_dir + '/src/language',
+ pkg_dir + '/src/language/providers',
+ pkg_dir + '/src/language/providers/intellisense/',
+ pkg_dir + '/src/launchWizard',
+ pkg_dir + '/src/styles',
+ pkg_dir + '/src/tdmlEditor',
+ ...serverPackageFolders,
+ ].forEach((folder) => {
+ if (!fs.existsSync(folder)) {
+ fs.mkdirSync(folder, { recursive: true })
+ }
+ })
for (const { from, to } of patterns) {
- from.includes('.')
+ fs.statSync(from).isFile()
? fs.copyFileSync(from, to)
: fs.cpSync(from, to, { recursive: true })
}
},
}
}
-const shouldMinify = process.env.MINIFY === '1'
-export default defineConfig({
- resolve: {
- alias: {
- ...localModuleAliases,
- },
- extensions: ['.ts', '.js'],
- },
- build: {
- sourcemap: true,
-
- minify: shouldMinify ? 'esbuild' : false,
-
- outDir: path.resolve(__dirname, '../dist/package/dist/ext'),
- emptyOutDir: true,
+const shouldMinify = process.env.MINIFY === '1'
Review Comment:
I believe you can do it either way. I believe we use the env variable right
now since we just moved from webpack to vite. We might want to do more testing
to test if enabling minify would break anything in the VSIX if enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
