github-code-scanning[bot] commented on code in PR #447:
URL: https://github.com/apache/datasketches-java/pull/447#discussion_r1233214408
##########
src/main/java/org/apache/datasketches/kll/KllFloatsSketch.java:
##########
@@ -336,6 +350,10 @@
abstract float getMaxFloatItem();
abstract float getMinFloatItem();
+
+ final int getSingleItemBytes() {
Review Comment:
## Missing Override annotation
This method overrides [KllSketch.getSingleItemBytes](1); it is advisable to
add an Override annotation.
[Show more
details](https://github.com/apache/datasketches-java/security/code-scanning/585)
##########
src/main/java/org/apache/datasketches/kll/KllDoublesSketch.java:
##########
@@ -336,6 +350,10 @@
abstract double getMaxDoubleItem();
abstract double getMinDoubleItem();
+
+ final int getSingleItemBytes() {
Review Comment:
## Missing Override annotation
This method overrides [KllSketch.getSingleItemBytes](1); it is advisable to
add an Override annotation.
[Show more
details](https://github.com/apache/datasketches-java/security/code-scanning/584)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
