leerho commented on PR #447: URL: https://github.com/apache/datasketches-java/pull/447#issuecomment-1668221632
I think the KllItemsSketch is ready for review. Creating the generic sketch required considerable modifications of the floats and doubles versions to accommodate additional abstractions. Nevertheless, much of the code is common with branches in strategic places to accommodate the specific data types. Nearly all of the tests, however, had to be duplicated into generic-specific test classes. The ArrayOf*SerDe classes had to be extended considerably to make the code simpler to write. The changes will not impact previous uses of these classes. Nonetheless, I am open to instead of modifying all of these set of classes, I could create a dedicated SerDe class for the use of the KLL sketches (and in the future others). There is a lot to review. Nonetheless, there should not be any changes to the public API, with one exception. there is one change to 2 import statements because the new versions of 2 extended classes reduced them to only a few lines of code, where it made more sense to pull these two classes into their parent class as an inner class. Nevertheless, if the reviewers feel this violates the minor release criteria, I can easily pull these two classes out as separate classes. I have created two slides to help you navigate the class hierarchy.   -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
