leerho opened a new pull request, #535: URL: https://github.com/apache/datasketches-cpp/pull/535
The cross-language tests read Java-generated `.sk` files from a top-level directory named `java/`, which suggests Java source code. This moves them to `serialization_test_data/java_generated_files/`, the same layout datasketches-java and datasketches-go use (`serialization_test_data/<language>_generated_files`), which leaves room for `cpp_` and `go_generated_files` later. Changes: - **14 `*_deserialize_from_java` tests** now read from `serialization_test_data/java_generated_files/`. - **`serde_compat` workflow:** checks out datasketches-java into `datasketches-java/` instead of `java/`, and copies its generated files into the new directory. - **`.gitignore`:** replaces `java` with `serialization_test_data/`, `datasketches-java/` and `*.sk`, so sketch snapshots can never be committed or end up in a release. Verified locally with the current Java snapshots from datasketches-tck (Java pin 059b5a9) in the new directory and `-DSERDE_COMPAT=true`: all 17 test suites pass, including every `[serde_compat]` case. With the directory absent, the `[serde_compat]` cases fail, confirming the tests read the new location. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
