AlexanderSaydakov commented on code in PR #535: URL: https://github.com/apache/datasketches-cpp/pull/535#discussion_r4185897440
########## .gitignore: ########## @@ -42,4 +42,7 @@ _*/ !__init__.py docs -java +# Cross-language test data: sketch snapshots and the datasketches-java checkout used to generate them +serialization_test_data/ +datasketches-java/ +*.sk Review Comment: The new `*.sk` line ignores `.sk` files in every directory of the repository, not only the generated ones. The repository already commits `.sk` files that tests read from disk, such as `quantiles/test/Qk128_n50_v0.3.0.sk`, `kll/test/kll_sketch_float_one_item_v1.sk` and `tdigest/test/tdigest_ref_k100_n10000_double.sk`. Files that are already tracked are not affected. If a contributor adds a new `.sk` test file, though, `git add` skips it without an error and `git status` does not list it. The test then passes on that contributor's machine but fails in CI and in clean checkouts, because the file was never committed. The `serialization_test_data/` and `datasketches-java/` lines already cover the generated files. Could `*.sk` be removed, or limited to the repository root as `/*.sk`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
