leerho opened a new pull request, #537: URL: https://github.com/apache/datasketches-cpp/pull/537
Reverts #476, as agreed with @proost on #533. The C++ array-of-strings (AoS) tuple sketch hashes keys as UTF-8, while Java's AoS sketch hashes them as UTF-16LE, so the two produce different hashes for the same keys and their sketches can't be combined correctly (#533). The C++ AoS sketch has never been released, so removing it now affects no users and keeps 5.3.0 from shipping an incompatible format. The encoding policy is being discussed on dev@: https://lists.apache.org/thread/5vlbnodmw8h5s0oc1988f4pdhkjnv8qw. The sketch will be rewritten once that's agreed. - Removes the 1,177 lines #476 added and restores the 4 lines it changed. Nothing else in the repo depends on the AoS code. - All 17 test suites pass locally. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
