leerho commented on code in PR #537:
URL: https://github.com/apache/datasketches-cpp/pull/537#discussion_r4174500771
##########
tuple/include/array_tuple_sketch.hpp:
##########
@@ -36,32 +34,27 @@ class array {
public:
using value_type = T;
using allocator_type = Allocator;
- using alloc_traits = std::allocator_traits<Allocator>;
- explicit array(uint8_t size, const T& value, const Allocator& allocator =
Allocator()):
+ explicit array(uint8_t size, T value, const Allocator& allocator =
Allocator()):
allocator_(allocator), size_(size), array_(allocator_.allocate(size_)) {
- init_values(value, std::is_trivially_copyable<T>());
+ std::fill(array_, array_ + size_, value);
Review Comment:
Agreed, and the same applies to the other generic `array<T>` changes from
#476 (moved-from size reset, the size check in `operator==`, element
construction/destruction). None are AoS-specific, and array-of-doubles uses the
same class. The revert now keeps `array_tuple_sketch.hpp` exactly as it is on
master and only removes the AoS files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
