proost commented on code in PR #569:
URL: https://github.com/apache/datasketches-cpp/pull/569#discussion_r4547309537


##########
kll/include/kll_sketch_impl.hpp:
##########
@@ -753,6 +767,21 @@ void kll_sketch<T, C, 
A>::add_empty_top_level_to_completely_full_sketch() {
   levels_[num_levels_] = new_total_cap; // initialize the new "extra" index at 
the top
 }
 
+// Grows the items buffer of a one-level sketch when it is full and smaller 
than k.
+// Compaction starts only when the buffer is full at k items, so growing does 
not change the result.
+template<typename T, typename C, typename A>
+void kll_sketch<T, C, A>::grow_items() {

Review Comment:
   Oh, Thank you. you are right. It happens master branch also. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to