leerho commented on PR #569: URL: https://github.com/apache/datasketches-cpp/pull/569#issuecomment-6887134935
@stojkomilos thanks, and thanks @proost for the approval. #573 is merged; [apache/datasketches-cpp#558 · perf: kll_sketch allocates its…](https://github.com/apache/datasketches-cpp/pull/558) is next. Once [apache/datasketches-cpp#558 · perf: kll_sketch allocates its…](https://github.com/apache/datasketches-cpp/pull/558) is merged this needs a rebase, and it will conflict in kll_sketch.hpp and kll_sketch_impl.hpp as well as the tests, because [apache/datasketches-cpp#558 · perf: kll_sketch allocates its…](https://github.com/apache/datasketches-cpp/pull/558) makes the item storage lazy and adds reserve(). In the rebase, allocate_items() should allocate your smaller starting buffer, and reserve() should keep its documented meaning: allocate the storage needed before the first compaction, which with your growth means growing to the full size. Happy to do that rebase here with maintainer edits if you prefer; just say so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
