e2corporation commented on code in PR #3496:
URL:
https://github.com/apache/incubator-devlake/pull/3496#discussion_r1003270108
##########
config-ui/src/components/blueprints/create-workflow/DataScopes.jsx:
##########
@@ -144,27 +140,22 @@ const DataScopes = (props) => {
disabled={isRunning}
placeholder='username/repo, username/another-repo'
values={
- projects[configuredConnection.id]?.map(
- (p) => p.value
- ) || []
+ selectedScopeEntities?.map((p) => p.value) || []
}
fill={true}
onChange={(values) =>
- setProjects((p) => ({
- ...p,
- [configuredConnection.id]: [
- ...values.map(
- (v, vIdx) =>
- new GitHubProject({
- id: v,
- key: v,
- title: v,
- value: v,
- type: 'string'
- })
- )
- ]
- }))
+ setScopeEntities([
+ ...values.map(
+ (v, vIdx) =>
+ new GitHubProject({
Review Comment:
@likyh I see, it looks like the `TagInput` component I created earlier is
limited for Github use only. Ideally this `<TagInput>.....` sub-component
should be extracted in the future to `ProjectsSelector`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
