e2corporation commented on code in PR #3496:
URL:
https://github.com/apache/incubator-devlake/pull/3496#discussion_r1012948802
##########
config-ui/src/components/blueprints/ProviderTransformationSettings.jsx:
##########
@@ -45,24 +44,7 @@ const withTransformationSettings = (
)
const ProviderTransformationSettings = (props) => {
- const {
Review Comment:
To clarify, while `props` is being spread and these props are not
technically in use, I think it's useful to reference these props in case this
file is further extended and this makes it clear from a documentation
standpoint _what_ props we expected `ProviderTransformationSettings` to depend
on. If you choose to remove them, move the props to a DocBlock comment instead.
It's cleaner to to just spread `props` from a development standpoint in case
we want to extend dependencies to all transformation settings components, we
only have to make that change in one place (where ProviderTransforationSettings
is implemented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
