klesh opened a new pull request, #5803:
URL: https://github.com/apache/incubator-devlake/pull/5803

   ### Summary
   Currently, we have 2 `iso8601time` structs defined in 
`helpers/pluginhelper/api` and `helpers/utils` which is certainly a mistake. 
Another problem is both `iso8601time` and `csttime` were put into `helpers/api` 
which is not the right place for such commonly used structs. This PR fixes 
these problems.
   
   1. delete `iso8601time` in the `helpers/utils`
   2. move `iso8601time` and `csttime` from `helpers/pluginhelper/api` to 
`core/models/common` package
   3. all **archived** models use plain `time.Time` instead of the 
`iso8601time` or `csttime` because they must be immutable and they don't need 
the features offered by these structs.
    
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to