d4x1 commented on code in PR #5803:
URL:
https://github.com/apache/incubator-devlake/pull/5803#discussion_r1282980112
##########
backend/core/models/common/iso8601time.go:
##########
@@ -77,7 +77,7 @@ func init() {
// Iso8601Time is type time.Time
type Iso8601Time struct {
- time time.Time
+ Time time.Time
Review Comment:
If `Time` field is not private, then method `Iso8601Time.ToTime` will be
duplicated.
Can we delete it ?
##########
backend/impls/dalgorm/db_mapper.go:
##########
@@ -33,7 +34,7 @@ func ToDatabaseMap(tableName string, m map[string]any)
map[string]any {
continue
}
if str, ok := v.(string); ok {
- t, err := api.ConvertStringToTime(str)
+ t, err := common.ConvertStringToTime(str)
Review Comment:
`common` is under `models` package, `ConvertStringToTime` is a function, can
we put it to `pluginhelper`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
