eye-gu commented on code in PR #14829:
URL:
https://github.com/apache/dolphinscheduler/pull/14829#discussion_r1309555583
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java:
##########
@@ -1897,7 +1897,7 @@ public void submitStandByTask() throws
StateEventHandleException {
TaskInstance task;
while ((task = readyToSubmitTaskQueue.peek()) != null) {
// stop tasks which is retrying if forced success happens
- if (task.taskCanRetry()) {
+ if (task.getId() != null && task.taskCanRetry()) {
Review Comment:
When a task fails and retried, a new task instance will be created using the
retryTaskInstance method, and then inserted into the readyToSubmitTaskQueue
using the addTaskToStandByList method. The instance ID is null and the status
is failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
