Gallardot commented on code in PR #16042:
URL:
https://github.com/apache/dolphinscheduler/pull/16042#discussion_r1610868287
##########
deploy/kubernetes/dolphinscheduler/Chart.yaml:
##########
@@ -35,11 +35,11 @@ type: application
# This is the chart version. This version number should be incremented each
time you make changes
# to the chart and its templates, including the app version.
-version: 3.1.0
+version: 3.2.2
# This is the version number of the application being deployed. This version
number should be
# incremented each time you make changes to the application.
-appVersion: 3.1.0
+appVersion: 3.2.2
Review Comment:
I don't think this `appVersion` should be changed.
`dolphinscheduler.master.labels` quotes `appVersion`
https://github.com/apache/dolphinscheduler/blob/56ecec779ca7877c1cad9ab27fcd3a7055b8e74a/deploy/kubernetes/dolphinscheduler/templates/_helpers.tpl#L51-L64
And `dolphinscheduler.master.labels` as master's matchLabels, but
matchLabels are immutable, which means that, Updating helm charts for an
already deployed dolphinscheduler will fail
https://github.com/apache/dolphinscheduler/blob/56ecec779ca7877c1cad9ab27fcd3a7055b8e74a/deploy/kubernetes/dolphinscheduler/templates/statefulset-dolphinscheduler-master.yaml#L27-L29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
