SbloodyS commented on code in PR #16042:
URL:
https://github.com/apache/dolphinscheduler/pull/16042#discussion_r1611858806
##########
dolphinscheduler-api/pom.xml:
##########
@@ -74,7 +74,7 @@
<dependency>
<groupId>org.apache.dolphinscheduler</groupId>
- <artifactId>dolphinscheduler-task-all</artifactId>
+ <artifactId>dolphinscheduler-task-all-prune</artifactId>
Review Comment:
What is this?
##########
dolphinscheduler-api-test/dolphinscheduler-api-test-case/pom.xml:
##########
@@ -46,5 +46,15 @@
<artifactId>dolphinscheduler-api</artifactId>
<version>dev-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.httpcomponents</groupId>
+ <artifactId>httpclient</artifactId>
+ <version>4.5.13</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.httpcomponents</groupId>
+ <artifactId>httpmime</artifactId>
+ <version>4.5.13</version>
+ </dependency>
Review Comment:
I don't see any related test cases being added. Why add this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
