SbloodyS commented on code in PR #18384:
URL:
https://github.com/apache/dolphinscheduler/pull/18384#discussion_r3488976725
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/UsersServiceImpl.java:
##########
@@ -358,6 +371,10 @@ public User updateUser(User loginUser,
if (StringUtils.isNotEmpty(userName)) {
+ if (isNotPasswordAuthenticationMode()) {
+ throw new
ServiceException(Status.OPERATION_NOT_ALLOWED_IN_NON_PASSWORD_MODE);
Review Comment:
This rejects unchanged usernames too. Normal non-credential edits such as
email/phone/tenant/state now fail in LDAP/OIDC/SSO mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
