SbloodyS commented on code in PR #18384:
URL:
https://github.com/apache/dolphinscheduler/pull/18384#discussion_r3526821955
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/UsersServiceImpl.java:
##########
@@ -101,6 +103,20 @@ public class UsersServiceImpl extends BaseServiceImpl
implements UsersService {
@Autowired
private SessionService sessionService;
+ @Value("${security.authentication.type:PASSWORD}")
+ private String securityAuthenticationType =
AuthenticationType.PASSWORD.name();
+
+ @Value("${security.authentication.oauth2.enable:false}")
+ private boolean oauth2Enabled;
+
+ private boolean isPasswordManagementDisabled() {
+ if (oauth2Enabled) {
+ return true;
+ }
+ return StringUtils.isNotBlank(securityAuthenticationType)
+ &&
!AuthenticationType.PASSWORD.name().equals(securityAuthenticationType);
+ }
Review Comment:
This is the same kind of thing. For users, it is an incompatible changes.
Please submit it in the current PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
