SbloodyS commented on code in PR #9840:
URL: https://github.com/apache/dolphinscheduler/pull/9840#discussion_r861480817
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkConstants.java:
##########
@@ -24,19 +24,48 @@ private FlinkConstants() {
}
/**
- * flink
+ * flink command
+ * usage: flink run [OPTIONS] <jar-file> <arguments>
+ */
+ public static final String FLINK_COMMAND = "flink";
+ public static final String FLINK_RUN = "run";
+
+ /**
+ * flink sql command
+ * usage: sql-client.sh -i <initialization file>, -j <JAR file>, -f
<script file>...
+ */
+ public static final String FLINK_SQL_COMMAND = "sql-client.sh";
Review Comment:
> I get it! I think there are two ways： （1）Edit the initialization script in
[**resource center**], select this resource when creating a task, and then
specify -i directly in [**pption parameters**]. This way I just took off this
pr to verify that it works. （2）The front end provides **two** editors, one for
filling in the user's initialization script and one for filling in FlinkSQL,
which may be a little clearer. Could you help me with a better solution? We'll
just optimize part of code immediately, Grazie！
Since we already have a sql editor for FlinkSQL's ```DML``` scripts. I think
the second option is friendly to both users and first-time contributor. We can
implement the first option in the next PR and provide it to users if you wish.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
