SbloodyS commented on code in PR #9840:
URL: https://github.com/apache/dolphinscheduler/pull/9840#discussion_r861437057
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkConstants.java:
##########
@@ -24,19 +24,48 @@ private FlinkConstants() {
}
/**
- * flink
+ * flink command
+ * usage: flink run [OPTIONS] <jar-file> <arguments>
+ */
+ public static final String FLINK_COMMAND = "flink";
+ public static final String FLINK_RUN = "run";
+
+ /**
+ * flink sql command
+ * usage: sql-client.sh -i <initialization file>, -j <JAR file>, -f
<script file>...
+ */
+ public static final String FLINK_SQL_COMMAND = "sql-client.sh";
Review Comment:
```-jar``` supplement can be added later is ok to me. However, almost 90% of
the Flink SQL related operations need to be performed based on ```-i```. I
think it's needed in flink sql feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
