imay commented on a change in pull request #2046: Changed replace NewStatus
with Status
URL: https://github.com/apache/incubator-doris/pull/2046#discussion_r337946193
##########
File path: be/src/olap/utils.cpp
##########
@@ -1432,9 +1451,10 @@ OLAPStatus dir_walk(const string& root,
struct dirent* direntp = NULL;
dirp = opendir(root.c_str());
if (dirp == nullptr) {
- NewStatus status = IOError(strings::Substitute("opendir $0 failed",
root), errno);
- LOG(WARNING) << status.ToString();
- if (status.IsDiskFailure()) {
+ Status status = disk_error("opendir failed", errno);
Review comment:
1. After you replace NewStatus, it is not used by anyone. You should remove
these files and modify NOTICE too.
2. You can reimplement this function with interface in env.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
