imay commented on a change in pull request #2046: Changed replace NewStatus 
with Status
URL: https://github.com/apache/incubator-doris/pull/2046#discussion_r337945061
 
 

 ##########
 File path: be/src/olap/utils.cpp
 ##########
 @@ -1424,6 +1425,24 @@ int Errno::no() {
     return errno;
 }
 
+static Status disk_error(const std::string& context, int16_t err) {
 
 Review comment:
   We have this code in env/env_posix.cpp, should reuse it other than coping it 
again.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to