CalvinKirs commented on code in PR #19655:
URL: https://github.com/apache/doris/pull/19655#discussion_r1202058939
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/StreamLoadStmt.java:
##########
@@ -147,12 +141,10 @@ public Separator getLineDelimiter() {
return lineDelimiter;
}
- @Override
Review Comment:
I mean, why did you remove the `@Override` annotation, although Java does
not mandate the use of the `@Override` annotation, but we still strongly
recommend using this annotation to clarify the code intent and improve code
readability and maintainability. If the `@Override` annotation is not used when
implementing the interface method, the compiler will not give warnings or error
prompts when the method signature has typos or parameter type mismatches, which
may lead to hard-to-find errors .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
