CalvinKirs commented on code in PR #19655:
URL: https://github.com/apache/doris/pull/19655#discussion_r1202071023
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/StreamLoadStmt.java:
##########
@@ -452,14 +434,26 @@ private void setLineDelimiter(String oriLineDelimiter)
throws AnalysisException
lineDelimiter.analyze();
}
- @Override
public long getMemLimit() {
return execMemLimit;
}
- @Override
public double getMaxFilterRatio() {
return maxFilterRatio;
}
-}
+ @Override
+ public List<? extends DataDesc> getDataDescList() {
+ return null;
+ }
+
+ @Override
+ public ResourceDesc getResourceDesc() {
+ return null;
+ }
+
+ @Override
+ public LoadType getLoadType() {
+ return null;
+ }
+}
Review Comment:
It is not advisable to return null directly, please re-evaluate whether the
design of the interface is reasonable, or at least you should throw an error
similar to `NotSupport...`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
