zhannngchen commented on code in PR #20182:
URL: https://github.com/apache/doris/pull/20182#discussion_r1209293692
##########
be/src/olap/rowset/segment_v2/bloom_filter_index_writer.h:
##########
@@ -63,6 +64,38 @@ class BloomFilterIndexWriter {
DISALLOW_COPY_AND_ASSIGN(BloomFilterIndexWriter);
};
+class PrimaryKeyBloomFilterIndexWriterImpl : public BloomFilterIndexWriter {
Review Comment:
Add a comment to explain that why do we need an independent impl for pk?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
