zhannngchen commented on code in PR #20182:
URL: https://github.com/apache/doris/pull/20182#discussion_r1209302391
##########
be/src/olap/rowset/segment_v2/bloom_filter_index_writer.cpp:
##########
@@ -174,6 +174,64 @@ class BloomFilterIndexWriterImpl : public
BloomFilterIndexWriter {
} // namespace
+void PrimaryKeyBloomFilterIndexWriterImpl::add_values(const void* values,
size_t count) {
+ const Slice* v = (const Slice*)values;
Review Comment:
can we use reserve() to avoid additional copy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
