yiguolei commented on code in PR #22442:
URL: https://github.com/apache/doris/pull/22442#discussion_r1307166775
##########
be/src/olap/data_dir.cpp:
##########
@@ -379,6 +381,21 @@ Status DataDir::load() {
if (rowset_meta->is_local()) {
rowset_meta->set_fs(local_fs);
}
+ if (rowset_meta->has_delete_predicate()) {
+ // copy the delete sub pred v1 to check then
+ auto orig_delete_sub_pred =
rowset_meta->delete_predicate().sub_predicates();
+ auto* delete_pred = rowset_meta->mutable_delete_pred_pb();
+ DeleteHandler::convert_to_sub_pred_v2(delete_pred,
rowset_meta->tablet_schema());
Review Comment:
If the predicate is already delete pred v2, then you also rewrite the rowset
meta. It is useless. And will cause the BE restart time very long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
