yiguolei commented on code in PR #22442:
URL: https://github.com/apache/doris/pull/22442#discussion_r1308092971
##########
be/src/olap/delete_handler.cpp:
##########
@@ -112,6 +147,23 @@ std::string DeleteHandler::construct_sub_predicates(const
TCondition& condition)
return condition_str;
}
+std::string DeleteHandler::trans_op(const std::string& opt) {
+ std::string op = string(opt);
Review Comment:
@gavinchou Do not use so many static functions. If this function will not
be used other place. It is useless to make it as a static function. And we
should make sure that this function will not be used in other classes because
it is very very ticky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
