yiguolei commented on code in PR #23855:
URL: https://github.com/apache/doris/pull/23855#discussion_r1315254408


##########
be/src/olap/rowset/segment_v2/binary_prefix_page.cpp:
##########
@@ -215,7 +216,10 @@ Status BinaryPrefixPageDecoder::next_batch(size_t* n, 
vectorized::MutableColumnP
     // read and copy values
     for (size_t i = 0; i < max_fetch; ++i) {
         dst->insert_data((char*)(_current_value.data()), 
_current_value.size());
-        _read_next_value();
+        if (_next_ptr >= _footer_start) {

Review Comment:
   This is maybe useless, because it should not happen. If this case happens, I 
think there is a fatal bug. BE should log fatal here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to