bobhan1 commented on code in PR #23855:
URL: https://github.com/apache/doris/pull/23855#discussion_r1315256277
##########
be/src/olap/rowset/segment_v2/binary_prefix_page.cpp:
##########
@@ -215,7 +216,10 @@ Status BinaryPrefixPageDecoder::next_batch(size_t* n,
vectorized::MutableColumnP
// read and copy values
for (size_t i = 0; i < max_fetch; ++i) {
dst->insert_data((char*)(_current_value.data()),
_current_value.size());
- _read_next_value();
+ if (_next_ptr >= _footer_start) {
Review Comment:
it will always try to decode the entry at `_footer_start `(a invalid
position) after it read the last value of the this page. We found this bug
after https://github.com/apache/doris/pull/23425 makes `Status::Corruption`
print stacktrace and we found that be.INFO are full of stacktrace of
`Status::Corruption` from `_decode_value_lengths`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
