yiguolei commented on code in PR #26191:
URL: https://github.com/apache/doris/pull/26191#discussion_r1378863887
##########
be/src/olap/in_list_predicate.h:
##########
@@ -134,9 +121,8 @@ class InListPredicateBase : public ColumnPredicate {
} else if constexpr (Type == TYPE_DECIMALV2) {
HybridSetBase::IteratorBase* iter = hybrid_set->begin();
while (iter->has_next()) {
- const DecimalV2Value* value = (const
DecimalV2Value*)(iter->get_value());
- decimal12_t decimal12 = {value->int_value(),
value->frac_value()};
- _values->insert(&decimal12);
+ const auto* value = (const
DecimalV2Value*)(iter->get_value());
+ _values->insert(value);
iter->next();
}
} else if constexpr (Type == TYPE_DATE) {
Review Comment:
should also modify datev1 and datetimev1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
