yiguolei commented on code in PR #26191:
URL: https://github.com/apache/doris/pull/26191#discussion_r1378865207
##########
be/src/olap/in_list_predicate.h:
##########
@@ -395,6 +371,16 @@ class InListPredicateBase : public ColumnPredicate {
if (bf->test_bytes(reinterpret_cast<const char*>(value),
sizeof(uint24_t))) {
return true;
}
+ } else if constexpr (Type == PrimitiveType::TYPE_DECIMALV2) {
+ // DecimalV2 using decimal12_t in bloom filter in storage
layer,
+ // should convert value to decimal12_t
+ const T* value = (const T*)(iter->get_value());
+ decimal12_t decimal12_t_val(value->int_value(),
value->frac_value());
+ if (bf->test_bytes(
+ const_cast<char*>(reinterpret_cast<const
char*>(&decimal12_t_val)),
+ sizeof(decimal12_t))) {
+ return true;
Review Comment:
what about datev1 and datetimev1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
