github-actions[bot] commented on code in PR #24788:
URL: https://github.com/apache/doris/pull/24788#discussion_r1400100060
##########
be/src/olap/merger.cpp:
##########
@@ -363,4 +383,21 @@ Status Merger::vertical_merge_rowsets(TabletSharedPtr
tablet, ReaderType reader_
return Status::OK();
}
+void Merger::_generate_key_group_cluster_key_idxes(
Review Comment:
warning: method '_generate_key_group_cluster_key_idxes' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void Merger::_generate_key_group_cluster_key_idxes(
```
##########
be/src/olap/rowset/segment_v2/segment.cpp:
##########
@@ -401,16 +401,20 @@ Status Segment::new_inverted_index_iterator(const
TabletColumn& tablet_column,
return Status::OK();
}
-Status Segment::lookup_row_key(const Slice& key, bool with_seq_col,
RowLocation* row_location) {
+Status Segment::lookup_row_key(const Slice& key, bool with_seq_col, bool
with_rowid,
Review Comment:
warning: function 'lookup_row_key' exceeds recommended size/complexity
thresholds [readability-function-size]
```cpp
Status Segment::lookup_row_key(const Slice& key, bool with_seq_col, bool
with_rowid,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/rowset/segment_v2/segment.cpp:403:** 85 lines including
whitespace and comments (threshold 80)
```cpp
Status Segment::lookup_row_key(const Slice& key, bool with_seq_col, bool
with_rowid,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
