freemandealer commented on code in PR #24788:
URL: https://github.com/apache/doris/pull/24788#discussion_r1401639299
##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -361,7 +361,8 @@ bool
BetaRowsetWriter::_check_and_set_is_doing_segcompaction() {
Status BetaRowsetWriter::_segcompaction_if_necessary() {
Status status = Status::OK();
if (!config::enable_segcompaction || !_context.enable_segcompaction ||
- !_check_and_set_is_doing_segcompaction()) {
+ !_check_and_set_is_doing_segcompaction() ||
+ !_context.tablet_schema->cluster_key_idxes().empty()) {
Review Comment:
@mymeiyi This will break seg compaction, causing _segcompacting_cond never
notified. I suggest you put your new condition before
_check_and_set_is_doing_segcompaction. And do me a favor: add a comment here to
warn other developers to leave _check_and_set_is_doing_segcompaction as the
last condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
