acelyc111 commented on a change in pull request #5654:
URL: https://github.com/apache/incubator-doris/pull/5654#discussion_r613178145



##########
File path: be/src/common/config.h
##########
@@ -286,6 +286,10 @@ CONF_mInt64(min_compaction_failure_interval_sec, "600"); 
// 10 min
 CONF_mInt32(min_compaction_threads, "10");
 CONF_mInt32(max_compaction_threads, "10");
 
+// This config can be set to limit thread number in tablet meta checkpoint 
thread pool.
+CONF_mInt32(min_meta_checkpoint_threads, "10");
+CONF_mInt32(max_meta_checkpoint_threads, "10");

Review comment:
       Thread count is not mutable, use CONF_Int32 instead, and we can just set 
a MAX thread count, leave MIN thread count as default value which is 0. BTW, 
you can optimize compaction_threads like this.
   And how about set the default value to -1, which means use the data 
directory count as the thread count, which is the previous behavior?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to