acelyc111 commented on a change in pull request #5654:
URL: https://github.com/apache/incubator-doris/pull/5654#discussion_r613917368
##########
File path: be/src/olap/olap_server.cpp
##########
@@ -81,16 +81,20 @@ Status StorageEngine::start_bg_threads() {
&_compaction_tasks_producer_thread));
LOG(INFO) << "compaction tasks producer thread started";
- // tablet checkpoint thread
- for (auto data_dir : data_dirs) {
- scoped_refptr<Thread> tablet_checkpoint_thread;
- RETURN_IF_ERROR(Thread::create(
- "StorageEngine", "tablet_checkpoint_thread",
- [this, data_dir]() {
this->_tablet_checkpoint_callback(data_dir); },
- &tablet_checkpoint_thread));
- _tablet_checkpoint_threads.emplace_back(tablet_checkpoint_thread);
+ int32_t max_checkpoint_thread_num = config::max_meta_checkpoint_threads;
+ // compatible with before behavior
Review comment:
```suggestion
```
##########
File path: be/src/common/config.h
##########
@@ -286,6 +286,9 @@ CONF_mInt64(min_compaction_failure_interval_sec, "600"); //
10 min
CONF_mInt32(min_compaction_threads, "10");
CONF_mInt32(max_compaction_threads, "10");
+// This config can be set to limit thread number in tablet meta checkpoint
thread pool.
Review comment:
```suggestion
// Thread count to do tablet meta checkpoint, -1 means use the data
directories count.
```
Or some words like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
