acelyc111 commented on pull request #5644: URL: https://github.com/apache/incubator-doris/pull/5644#issuecomment-820008360
> `Deserialization` here may be necessary. To ensure the tablet meta that will be stored in rocksdb is no problem and can be deserialized successfully, so deserializing the `meta_binary` here before saving it into rocksdb. > I think it may be not a good practice to remove this part of the code. I'm confused if it is possible that `SerializeToString` successfully but `ParseFromString` failed, maybe there are some historical reason? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
