xinghuayu007 commented on pull request #5644: URL: https://github.com/apache/incubator-doris/pull/5644#issuecomment-820079637
> > > `Deserialization` here may be necessary. To ensure the tablet meta that will be stored in rocksdb is no problem and can be deserialized successfully, so deserializing the `meta_binary` here before saving it into rocksdb. > > > I think it may be not a good practice to remove this part of the code. > > > > > > I'm confused if it is possible that `SerializeToString` successfully but `ParseFromString` failed, maybe there are some historical reason? > > I think it makes no sense to check that SerializeToString successfully but ParseFromString failed, because the next step is fatal error. the result is the same as we store it to rocksdb and get it then ParseFromString, finally fatal error. what's more, until now, I could not see any fatal error like 'SerializeToString successfully but ParseFromString failed'， may it is a bug in older version? > > I think SerializeToString performance is very important ,which may affect many operations on tablet, like publish version etc. > So，just need to do the simple thing to SerializeToString instead of adding ParseFromString check which would may cause poor performance agree! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
