HappenLee commented on code in PR #35136:
URL: https://github.com/apache/doris/pull/35136#discussion_r1610936251
##########
be/src/vec/columns/column_fixed_length_object.h:
##########
@@ -159,60 +161,65 @@ class ColumnFixedLengthObject final : public
COWHelper<IColumn, ColumnFixedLengt
memset(&_data[old_size * _item_size], 0, _item_size);
}
- void pop_back(size_t n) override { LOG(FATAL) << "pop_back not supported";
}
+ void pop_back(size_t n) override { resize(_item_count - n); }
Review Comment:
DCHECK or check `n <= _item_count`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
