HappenLee commented on code in PR #35136: URL: https://github.com/apache/doris/pull/35136#discussion_r1610937321
########## be/src/vec/columns/column_nullable.h: ########## @@ -353,23 +349,41 @@ class ColumnNullable final : public COWHelper<IColumn, ColumnNullable> { if (!nullable_rhs.is_null_at(row)) { nested_column->replace_column_data(*nullable_rhs.nested_column, row, self_row); - } else { - nested_column->replace_column_data_default(self_row); } } - void replace_column_data_default(size_t self_row = 0) override { - LOG(FATAL) << "should not call the method in column nullable"; - __builtin_unreachable(); - } - MutableColumnPtr convert_to_predicate_column_if_dictionary() override { nested_column = get_nested_column().convert_to_predicate_column_if_dictionary(); return get_ptr(); } double get_ratio_of_default_rows(double sample_ratio) const override { - return get_ratio_of_default_rows_impl<ColumnNullable>(sample_ratio); + if (sample_ratio <= 0.0 || sample_ratio > 1.0) { + LOG(FATAL) << "Value of 'sample_ratio' must be in interval (0.0; 1.0], but got: " + << sample_ratio; + } + static constexpr auto max_number_of_rows_for_full_search = 1000; Review Comment: MAX_NUMBER -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org