yujun777 commented on code in PR #37170:
URL: https://github.com/apache/doris/pull/37170#discussion_r1663378514
##########
be/src/olap/data_dir.cpp:
##########
@@ -906,8 +906,13 @@ void DataDir::disks_compaction_num_increment(int64_t
delta) {
}
Status DataDir::move_to_trash(const std::string& tablet_path) {
- Status res = Status::OK();
+ if (0 == config::trash_file_expire_time_sec) {
+ LOG(INFO) << "delete tablet dir " << tablet_path
+ << " directly due to trash_file_expire_time_sec is 0";
+ return io::global_local_filesystem()->delete_directory(tablet_path);
Review Comment:
after delete the tablet_path (it is root_dir/shard/tablet_id/schema_hash),
need delete path root_dir/shard/tablet_id if it is empty.
see line 950:
RETURN_IF_ERROR(delete_tablet_parent_path_if_empty(tablet_path))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
