yujun777 commented on code in PR #37170: URL: https://github.com/apache/doris/pull/37170#discussion_r1663384266
########## be/src/common/config.cpp: ########## @@ -322,7 +322,7 @@ DEFINE_mInt32(garbage_sweep_batch_size, "100"); DEFINE_mInt32(snapshot_expire_time_sec, "172800"); // It is only a recommended value. When the disk space is insufficient, // the file storage period under trash dose not have to comply with this parameter. -DEFINE_mInt32(trash_file_expire_time_sec, "259200"); +DEFINE_mInt32(trash_file_expire_time_sec, "86400"); Review Comment: maybe can change this default value to 0. not found any user case recover tablet from trash. it user really want to use trash, they need to manually set this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
