github-actions[bot] commented on code in PR #43525:
URL: https://github.com/apache/doris/pull/43525#discussion_r1834174268
##########
be/src/vec/exec/format/parquet/vparquet_reader.cpp:
##########
@@ -259,6 +259,10 @@ std::vector<tparquet::KeyValue>
ParquetReader::get_metadata_key_values() {
return _t_metadata->key_value_metadata;
}
+const FieldDescriptor ParquetReader::get_file_metadata_schema() {
Review Comment:
warning: return type 'const std::doris::vectorized::FieldDescriptor' is
'const'-qualified at the top level, which may reduce code readability without
improving const correctness [readability-const-return-type]
```suggestion
FieldDescriptor ParquetReader::get_file_metadata_schema() {
```
be/src/vec/exec/format/parquet/vparquet_reader.h:151:
```diff
- const FieldDescriptor get_file_metadata_schema();
+ FieldDescriptor get_file_metadata_schema();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
