wuwenchi commented on code in PR #43525:
URL: https://github.com/apache/doris/pull/43525#discussion_r1836621153


##########
be/src/vec/exec/format/table/iceberg_reader.h:
##########
@@ -218,7 +218,7 @@ class IcebergParquetReader final : public 
IcebergTableReader {
         parquet_reader->set_delete_rows(&_iceberg_delete_rows);
     }
 
-    Status _gen_col_name_maps(std::vector<tparquet::KeyValue> parquet_meta_kv);
+    Status _gen_col_name_maps(FieldDescriptor field_desc);

Review Comment:
   The orc format is originally associated according to the id, so there is no 
need to modify it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to