morrySnow commented on code in PR #45050:
URL: https://github.com/apache/doris/pull/45050#discussion_r1871158014
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/types/DataType.java:
##########
@@ -246,7 +246,16 @@ public static DataType
convertPrimitiveFromStrings(List<String> types) {
dataType = DateV2Type.INSTANCE;
break;
case "time":
- dataType = TimeType.INSTANCE;
+ switch (types.size()) {
+ case 1:
+ dataType = TimeV2Type.INSTANCE;
+ break;
+ case 2:
+ dataType =
TimeV2Type.of(Integer.parseInt(types.get(1)));
Review Comment:
if u add scale on timev2 type, u should also update timev2 type related
coersion just like datetimev2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
